Fix deprecated pkg_resources and use poetry#116
Merged
Conversation
Joel-Luca
force-pushed
the
jch/fix_pkg_resources
branch
2 times, most recently
from
00570f3 to
c24567a
Compare
This replaces the setuptools and adds dev dependencies for linting and releasing.
This is copied from other 4tw repos.
Joel-Luca
force-pushed
the
jch/fix_pkg_resources
branch
2 times, most recently
from
f87925e to
5245559
Compare
Joel-Luca
force-pushed
the
jch/fix_pkg_resources
branch
from
5245559 to
36a9b56
Compare
The pkg_resources have been deprecated for a long time...
Datetime values require a timezone info and the format_datetime function from babel requires a language code.
Joel-Luca
force-pushed
the
jch/fix_pkg_resources
branch
from
36a9b56 to
3465b7e
Compare
|
any reason for going just 3.12+ ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
The following checklist should help us to stick to our "definition of done":
[ ] Proposed changes include tests.[ ] Good error handling with useful messages